Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use savedStateHandle for the events and currentState to prevent crashes #5354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use savedStateHandle for the events and currentState to prevent crashes #5354

wants to merge 2 commits into from

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented Feb 27, 2025 •
edited
Loading

What does this do?

This PR uses the savedStateHandle to save the currentState and the events to avoid possible crashes when the devices are low on memory.

Also moved the impression event to the end of onGameEnded() in the case of gameState being null.

https://phabricator.wikimedia.org/T387418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

@Williamrai Williamrai Awaiting requested review from Williamrai Williamrai is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cooltey