Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language switcher #532

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Add language switcher #532

merged 2 commits into from
Feb 27, 2025

Conversation

samwilson
Copy link
Member

@samwilson samwilson commented Feb 16, 2025

Add a language-switching dropdown menu in the site footer.

Bug: T387426

@waldyrious
Copy link
Collaborator

A screenshot would be nice 🙏

@samwilson
Copy link
Member Author

Good point! This should also have a Phab task, for visibility. I've created T387426.

{% if lang %}
{{lang}}
{% else %}
({{code}})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fallback shouldn't really be necessary, but not all languages have names in Intuition yet. (I think T331584 is the task for that, and perhaps all_langs() should handle the fallback for us; that's part of the ToolforgeBundle.)

Copy link
Collaborator

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samwilson samwilson merged commit 995ceaa into main Feb 27, 2025
2 checks passed
@samwilson samwilson deleted the change-lang branch February 27, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants