Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Tracing fails with Unsatisfied Dependency #148

Open
t1 opened this issue Jun 18, 2023 · 7 comments
Open

Enabling Tracing fails with Unsatisfied Dependency #148

t1 opened this issue Jun 18, 2023 · 7 comments

Comments

@t1
Copy link
Contributor

t1 commented Jun 18, 2023

I use WF 28.0.1.Final with the feature pack 2.1.0.Final and the Galleon layers jaxrs-server, microprofile-graphql, and opentelemetry.

When I set smallrye.graphql.tracing.enabled to true, all calls result in a UnsatisfiedResolutionException: WELD-001334: Unsatisfied dependencies for type Tracer with qualifiers in InstanceImpl:251.

@t1
Copy link
Contributor Author

t1 commented Jun 19, 2023

I opened the issue here, because it looks like an integration issue. It works fine with quarkus.

@jmartisk
Copy link
Collaborator

Interesting, the smallrye.graphql.tracing.enabled property was removed, so if it still has any effect, then I forgot to remove it somewhere. It should just be turned on/off automatically.

It looks like WildFly doesn't support injecting a tracer directly via CDI, which I believe it should, and smallrye-graphql tries to obtain it that way. I'll need to figure out how else we can obtain it.

@t1
Copy link
Contributor Author

t1 commented Jun 19, 2023

When I don't enable it, then tracing works for REST, but not for GraphQL (services; we have a separate issue for GraphQL clients).

@t1
Copy link
Contributor Author

t1 commented Jun 20, 2023

Oh, before you are searching at the wrong place, I just saw that I may have confused the versions. I had a mismatch for a while by using 2.0.0.Final with WF28. The exception I reported may be from that setting after an incomplete re-provisioning; I can't reproduce it any more.

But it still doesn't work: GraphQL requests are not being reported as spans. And if I log the trace-id (via Span.current().getSpanContext().getTraceId()), it shows 00000000000000000000000000000000. I could share my reproducer, if it helps.

@t1
Copy link
Contributor Author

t1 commented Jun 20, 2023

Stupid me. I can reproduce it. I just still had a dummy producer for Tracers. Sorry for the confusion (too many topics in parallel, you know it).

@jmartisk
Copy link
Collaborator

Should you have a reproducer that would be great, I plan to look at it, but my schedule is quite crazy this week and the next

@t1
Copy link
Contributor Author

t1 commented Jun 21, 2023

I just published my reproducer: https://github.com/t1/wildfly-otel-demo

It's not super-urgent, but I'd like to suggest in my current project that we should go from our brittle and vintage logging/analytics stack to O11y... and we can't do that without support for GraphQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants