New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTracing integration + tests #2

Open

jmartisk opened this issue Jul 29, 2020 · 1 comment

Collaborator

jmartisk commented Jul 29, 2020

Verify that opentracing works as expected, it probably will work without significant problems, but we should cover it with a test

Collaborator Author

jmartisk commented Nov 4, 2020

Note mainly to self after almost a day of struggling with it:

The problem with this is that the (CDI) producer of io.opentracing.Tracer is appended to CDI-enabled deployments via a CDI extension (https://github.com/wildfly/wildfly/blob/21.0.0.Final/microprofile/opentracing-smallrye/src/main/java/org/wildfly/microprofile/opentracing/smallrye/TracingCDIExtension.java#L45), but then when the TracingService tries to look it up (https://github.com/smallrye/smallrye-graphql/blob/1.0.14/server/implementation-cdi/src/main/java/io/smallrye/graphql/cdi/tracing/TracingService.java#L135) it can't see the producer, because this code resides in a static module (io.smallrye.graphql), and beans added through CDI extensions are visible only by the BeanManager for the application's module, therefore the lookup doesn't return anything.
We need to find a way to propagate the producer of Tracer so that the io.smallrye.graphql module will see it, but I'm not sure how to do that. Adding a module dependency from io.smallrye.graphql to org.wildfly.extension.microprofile.opentracing-smallrye doesn't solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment