Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling enabled in browser as soon as enableBodyScroll is called once, regardless of number of locks #235

Open
silvenon opened this issue Oct 4, 2021 · 3 comments
Open

Scrolling enabled in browser as soon as enableBodyScroll is called once, regardless of number of locks #235

silvenon opened this issue Oct 4, 2021 · 3 comments

Comments

@silvenon
Copy link

silvenon commented Oct 4, 2021

Hey! I'm having a little trouble understanding how enabling scrolling is intended to work in this library. I see that elements are being tracked in the locks array, but this is only used for scrolling on mobile; in the browser scrolling enables as soon as I call enableBodyScroll, I would expect scrolling to be enabled once the last "lock" is cleared. 🤔
@diachedelic
Copy link
Collaborator

An astute observation! Can anybody provide some insight?

@silvenon
Copy link
Author

Would you accept a PR?

@silvenon silvenon mentioned this issue Oct 19, 2021
Merged
@rick-liruixin
Copy link

They stopped the repairs. I had to do it myself, in the same way, with a new version of typeScript. And fix these problems for everyone to use.

npm i body-scroll-lock-upgrade

repair log，Refer to the releases page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@diachedelic @silvenon @rick-liruixin