Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Trigger Other Actions doesnot work for certain actions #333

Closed
2 tasks done
ramonmi opened this issue Jun 7, 2024 · 5 comments
Closed
2 tasks done

[Bug] Trigger Other Actions doesnot work for certain actions #333

ramonmi opened this issue Jun 7, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ramonmi
Copy link

ramonmi commented Jun 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest Zotero and the latest plugin?

  • I have confirmed I'm using the latest Zotero and the latest plugin

Environment

  • OS: Win11
  • Zotero Version: 7.0.0-beta.84+71f83c0a3 (64-bit)
  • Plugin Version: 1.0.0-beta.42

Describe the bug

I add two actions in the Data (without quotes) but nothing happens when I trigger this action. Same as FeralFlora‘s description even using the latest plugin. #169 (reply in thread)
However, at least, the Format Chinese Annotations action can be triggered by the parent action.

Debug Output

(3)(+0000001): [Actions and Tags for Zotero] applyAction {"event":0,"operation":4,"data":"/**\n * Toggle Left Pane\n * @author MuiseDestiny, windingwind\n * @Usage Assign a shortcut\n * @link https://github.com/windingwind/zotero-actions-tags/discussions/169\n * @see https://github.com/windingwind/zotero-actions-tags/discussions/169\n */\nconst Zotero = require("Zotero");\nconst Zotero_Tabs = require("Zotero_Tabs");\nconst document = require("document");\n\nif (item) {\n return;\n}\n\nif (Zotero_Tabs.selectedType === "library") {\n const splitter = document.querySelector("#zotero-collections-splitter");\n if (splitter.getAttribute("state") == "collapsed") {\n splitter.setAttribute("state", "");\n return;\n } else {\n splitter.setAttribute("state", "collapsed");\n return;\n }\n} else {\n Zotero.Reader.getByTabID(\n Zotero_Tabs.selectedID\n )._internalReader.toggleSidebar();\n return;\n}","shortcut":"Ctrl,Alt,4","enabled":true,"menu":"","name":"Toggle Left Pane","showInMenu":{"item":false,"collection":false,"tools":false,"reader":false,"readerAnnotation":false}} {"itemID":7199,"triggerType":"shortcut"}

BTW, The Debug output is the same as the output when trigger the origin Toggle Left Pane action.

Anything else?

No response

@ramonmi ramonmi added the bug Something isn't working label Jun 7, 2024
@windingwind
Copy link
Owner

Could you please take a screenshot of your actions list?

@ramonmi
Copy link
Author

ramonmi commented Jun 9, 2024

Could you please take a screenshot of your actions list?

  • The normal example
    image

  • The abnormal case
    1

At least, the Attach File #290, and Copy Zotero link #290 are also not working. But the Rename attachment #291 is normal. So it may relate to the script itself.

@windingwind
Copy link
Owner

yes, please make sure you can run the sub-actions separately.

@ramonmi
Copy link
Author

ramonmi commented Jun 9, 2024

yes, please make sure you can run the sub-actions separately.

Yes, I can confirm that they can all run independently. I have been using them for a long time.

Copy link

github-actions bot commented Jun 9, 2024

🚀 This ticket has been resolved in v1.0.0-beta.44. See Release v1.0.0-beta.44 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants