Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the place where the comment is applied more visible #25

Open
Korb opened this issue Sep 7, 2023 · 1 comment
Open

Make the place where the comment is applied more visible #25

Korb opened this issue Sep 7, 2023 · 1 comment

Comments

@Korb
Copy link

Korb commented Sep 7, 2023

With Dark Docs2023.08.10:

Screenshot_2023-09-07_15-39-35

Vanile:

Screenshot_2023-09-07_15-39-57

@winghongchan
Copy link
Owner

It seems like the yellow highlight is part of the same <canvas> element of the rest of the document, so I can’t change the yellow highlight itself, nor can I target it to make it more visible.

→ Decreasing the “Document contrast while inverted” setting to 71 can slightly increase the contrast from 1.12 to 1.16.

I will consider changing how the Invert filter works, since increasing the brightness can drastically improve contrast between the yellow highlight and the page background to 1.29. However, this will take some testing to ensure the usability of Dark Docs and the appearance of the document.


(I apologize for my slow reply. I am focusing on my university studies and cannot spend as much time on Dark Docs as I did previously. I will have more time to work on Dark Docs in December.)
(It’s odd how without the document filter, the colour contrast between the yellow highlight and the white background is only 1.11, even though it looks higher contrast to my eyes than it does in dark mode.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants