Infinite loops on uncaught exceptions

[cwebber]

In switching guile-goblins from Fibers 1.0 to 1.10, I noticed that when exceptions occured, schedulers suddenly stopped working but also my cpu would shoot up to 100%. That's strange, that shouldn't happen, what gives?

I did a git-bisect against fibers to try to figure out where this started. The issue is introduced in 84addfb. I haven't checked for sure, but I'm pretty certain that what's happening is that where the scheduler previously was catching the exception in the individual task but the scheduler would continue looping, now the scheduler is breaking and not continuing on an individual error. Thus, it isn't feeding anything to the individual fibers, which start spin locking madly.

[cwebber]

One option is simply to revert 84addfb. Maybe @wingo might not like this; it fixes it, but it re-introduces whatever performance issue the commit was meant to address.

[aconchillo]

IMO, stability is always preferred over performance.

[wingo]

Do you have a test case?

[aconchillo]

@cwebber Probably completely unrelated, but I'm wondering if this commit c25dcb9 would fix the issue you are seeing. Available in Fibers 1.1.1.

[wingo]

Pretty sure this is fixed via #76, which is now in Guile main. Christine can you give a try with Guile from git and see if you are still having issues? Or otherwise close this one if you think it is fixed.