Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib patch #807

Open
nacho opened this issue Jan 11, 2023 · 5 comments
Open

glib patch #807

nacho opened this issue Jan 11, 2023 · 5 comments

Comments

@nacho
Copy link
Contributor

nacho commented Jan 11, 2023

@TingPing Hey can you remind me if there is a MR for this following patch? https://github.com/wingtk/gvsbuild/blob/main/gvsbuild/patches/glib/glib-package-installation-directory.patch

I think we should just go ahead and merge it in glib
@TingPing
Copy link
Member

The upstream bug is here: https://gitlab.gnome.org/GNOME/glib/-/issues/955 - It never merged. Feel free to open an MR with the patch and advocate for it.

@danyeaw
Copy link
Member

danyeaw commented Jan 21, 2023

@nacho I saw that you posted that you don't think it should be fixed in glib, do we need to keep it in gvsbuild?

@TingPing
Copy link
Member

I read his comment the other way. Revert the original change in GLib. It was only done for GEdit.

@nacho
Copy link
Contributor Author

nacho commented Jan 22, 2023

I read his comment the other way. Revert the original change in GLib. It was only done for GEdit.

Correct

@danyeaw
Copy link
Member

danyeaw commented Mar 18, 2023

Is there something we need to do for gvsbuild for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nacho @TingPing @danyeaw