You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When setting up nodetaint in a cluster we noticed that it was finding 0 daemonsets even though we believed we had it configured. After digging into the code I found that it is checking the spec.template.annotations which is the annotation that will end up on the ds pod -- not the ds itself.
This is a bit counter-intuitive, id expect it to check the annotation of the daemonset directly. Given this would be backwards incompatible maybe we could have it check both?
The text was updated successfully, but these errors were encountered:
When setting up nodetaint in a cluster we noticed that it was finding 0 daemonsets even though we believed we had it configured. After digging into the code I found that it is checking the spec.template.annotations which is the annotation that will end up on the ds pod -- not the ds itself.
This is a bit counter-intuitive, id expect it to check the annotation of the daemonset directly. Given this would be backwards incompatible maybe we could have it check both?
The text was updated successfully, but these errors were encountered: