Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Island fails when using i18 and prefixDefaultLocale set to true #12817

Closed
1 task
nima-hakimi opened this issue Dec 23, 2024 · 2 comments · Fixed by #13112
Closed
1 task

Server Island fails when using i18 and prefixDefaultLocale set to true #12817

nima-hakimi opened this issue Dec 23, 2024 · 2 comments · Fixed by #13112
Assignees
@ematipico
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: i18n Related to internalization (scope) feat: server islands Related to Server Islands (scope)

Comments

@nima-hakimi
Copy link

Astro Info

Astro                    v5.1.1
Node                     v22.5.1
System                   macOS (arm64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/node

If this issue only occurs in one browser, which browser is a problem?

Describe the Bug

Fetching the Server Island fails when using i18 and prefixDefaultLocale set to true. It fails with 404 when I use the following file structure: src/pages/[locale]/index.astro

What's the expected result?

The expected result would be to fetch the Server Island correctly.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-fmzsdm7p-mklde2ku?file=astro.config.mjs

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 23, 2024
@sasoria sasoria mentioned this issue Jan 2, 2025
Closed
1 task
@ascorbic ascorbic added - P3: minor bug An edge case that only affects very specific usage (priority) feat: server islands Related to Server Islands (scope) and removed needs triage Issue needs to be triaged labels Jan 17, 2025
@dallyh
Copy link

dallyh commented Jan 30, 2025

I'd like to bump this issue a little, server islands are a really great feature than cannot be used in this combination.

@ematipico ematipico added the feat: i18n Related to internalization (scope) label Jan 31, 2025
@ematipico ematipico self-assigned this Jan 31, 2025
@ematipico ematipico mentioned this issue Jan 31, 2025
Merged
@nima-hakimi
Copy link
Author

Thanks @ematipico 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ematipico ematipico

Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: i18n Related to internalization (scope) feat: server islands Related to Server Islands (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i18n): server island request withastro/astro
4 participants
@ascorbic @ematipico @dallyh @nima-hakimi