🐛 BUG: Can't stop typescript errors

[cdtut]

Describe the Bug

Can't stop typescript errors appearing.

Steps to Reproduce

Front matter

const array = [
  { required: '' },
  { required: '', optional: '' }
]
array[1].optional

optional is underlined in red and hovering explains error Property 'optional' does not exist on type '{ required: string; optional?: undefined; }'.ts(2339)

I tried to disable validation with "checkJs": false in jsconfig.json and "typescript.validate.enable": false in settings but it doesn't stop errors.

No error putting that code in .js file but error still in .astro file.

Using typescript is not requirement for astro so should not be required to write any typescript to stop these errors. They shouldn't appear if typescript checks are disabled.

[Princesseuh]

Astro is TypeScript only at this time, TypeScript cannot be disabled. Nonetheless, yes, I believe that option should be working

[cdtut]

Instead of "typescript.validate.enable": false can an extension specific setting be added to settings file disabling typescript errors in astro files? Can be people who don't want disable all typescript validation if they're writing typescript in non astro files but are writing astro as javascript (without type annotations which is valid typescript).

[Princesseuh]

We'd rather make that option work if that's a possibility

[cdtut]

Is there any workaround until fixed? Disruptive for developing and causes to miss important errors because so many things are underlined in red. Even every access under Astro.locals complains with error that property doesn't exist.

[cdtut]

@Princesseuh Can it be P1 bug? There are so many error everywhere. I can give more example. Cannot trust errors in IDE anymore because most of them are because of this extension instead of real problems with code. Trusting errors is more than nice to have I believe, it's very frustrating developer experience.

[Princesseuh]

@Princesseuh Can it be P1 bug? There are so many error everywhere. I can give more example. Cannot trust errors in IDE anymore because most of them are because of this extension instead of real problems with code. Trusting errors is more than nice to have I believe, it's very frustrating developer experience.

TypeScript errors are real errors.. I'm sorry this is affecting your experience so much, but it's a niche issue, people typically use TypeScript just fine. You can use // @ts-nocheck in the meantime

[cdtut]

TypeScript errors are real errors..

This is opinion and objectively wrong. There are many example that run and build fine but this extension still complain with error. Rule of thumb is if it runs without error in astro and browser it's not an error.

it's a niche issue, people typically use TypeScript just fine

People typically use javascript just fine. It is allowed to write vanilla javascript in astro and everyone should respect right to choose for own code.

[Princesseuh]

Fixed by volarjs/services@6f13b47, we'll release an update with it soon-ish

[cdtut]

Is it in 2.6.2?

[Princesseuh]

Nope, not yet sorry. There was an unexpected delay, unfortunately. The holidays period also delayed things a fair amount. Still definitely planned, though!

[cdtut]

Is it in 2.7.1?

[Princesseuh]

Yes, it should work now!

[cdtut]

I still have typescript errors like Property 'item' does not exist on type 'Element'. ts(2339). Is enough to set "typescript.validate.enable": false`?

[cdtut]

@Princesseuh working for you?

[Princesseuh]

Ah, it only seems to be working for certain kinds of errors, I'll take a look. Sorry for the inconvenience.

[cdtut]

@Princesseuh can you open this issue?

[Princesseuh]

I'll open an issue on the upstream project instead, since the code for this isn't in this repo

[cdtut]

@Princesseuh where to find that issue number?

[Princesseuh]

The option works as expected for me right now after the latest updates:

(removing the option shows a type error in both files)