Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide completions for git remotes with remote as prefix #2572

Open
3 tasks done
meganrogge opened this issue Feb 24, 2025 · 0 comments
Open
3 tasks done

provide completions for git remotes with remote as prefix #2572

meganrogge opened this issue Feb 24, 2025 · 0 comments

Comments

@meganrogge
Copy link

Sanity checks

  • My issue relates to a specific CLI completion spec (e.g. git checkout is missing options in git completion spec). If your issue is more general, please create your issue here: withfig/fig
  • I have searched github.com/withfig/autocomplete/issues and there are no duplicates of my issue
  • I would like to work on this.

What CLI tool does this relate to?

git

Which statement makes the most sense?

There is a bug with this completion spec

Issue Details

  1. When I type git commit and request completions, I expect to see origin/branch_name for example.
  2. This code prevents that from happening:

    autocomplete/src/git.ts

    Lines 92 to 96 in 7828841

    if (insertWithoutRemotes && name.startsWith("remotes/")) {
    name = name.slice(name.indexOf("/", 8) + 1);
    description = "Remote branch";
    }

These changes allow that to show up in the completions list:

https://github.com/microsoft/vscode/pull/241675/files

I'm wondering if you are open to this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant