Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker prop 'migrate' warning despite not using it. #3110

Open
2 of 7 tasks
king960 opened this issue May 31, 2024 · 4 comments
Open
2 of 7 tasks

Picker prop 'migrate' warning despite not using it. #3110

king960 opened this issue May 31, 2024 · 4 comments
Assignees
Labels
bug a bug in one of the components

Comments

@king960
Copy link

king960 commented May 31, 2024

Description

When creating a Picker and not using the 'migrate' flag, there's a warning about using the 'migration' prop.
Probably wrong check, as passing migrate=false does not trigger the warning.

Related to

  • Components
  • Demo
  • Docs
  • Typings

Steps to reproduce

Copy the code snippet and run. :)

Expected behavior

Using the 'migrate' flag with value either 'false' or 'true' triggers a warning.

Actual behavior

Not using the 'migrate' flag triggers the warning.
Using the 'migrate' flag with value 'false' does not trigger the warning.

More Info

"react-native-ui-lib": "^7.23.2"

Code snippet

<Picker
value={''}
onChange={(value) => setTeam(value)}
items={[{value: '1', label: 'one'}]}
/>



Screenshots/Video

Environment

  • React Native version:
  • React Native UI Lib version:

Affected platforms

  • Android
  • iOS
  • Web
@king960 king960 added the bug a bug in one of the components label May 31, 2024
@janoslc
Copy link

janoslc commented Jun 3, 2024

I can confirm this. I was searching for this usage, then realised they have this defaulted as true.
Take a look at node_modules/react-native-ui-lib/src/components/picker/index.js line 70.

If you set it to false manually Picker won't work properly. Kind of annoying, but I guess they will get it done if the new version if fully prepared.

@adids1221
Copy link
Contributor

Hi @king960 and @janoslc ,
The migrate prop will be deprecated in the next major version v8.
I think we can close this issue, make sure to migrate your code and remove the usage of the migrate prop.

@janoslc
Copy link

janoslc commented Aug 19, 2024

Hey @adids1221! Thank you for your response. We understood that migrate prop will be removed from the next major version. Our problem is that we don't use it, yet we get a warning as if we did.
Therefore the issue is valid, of course it's not a blocker, but it shouldn't warn us if we don't use migrate.

@janoslc
Copy link

janoslc commented Aug 30, 2024

Thank you @adids1221 for your work! The ticket can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in one of the components
Projects
None yet
Development

No branches or pull requests

3 participants