Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing or wrong suggestions using the rule @forward with prefix #201

Closed
MenSeb opened this issue Aug 7, 2024 · 3 comments · Fixed by #202
Closed

Missing or wrong suggestions using the rule @forward with prefix #201

MenSeb opened this issue Aug 7, 2024 · 3 comments · Fixed by #202

Comments

@MenSeb
Copy link
Contributor

MenSeb commented Aug 7, 2024

Hey, it's me again, sorry! haha

There seems to be more logic to update regarding the forward rule.

This time it includes logic using it with prefix, i.e. @forward './test' as test-*;

There are multiple test files to showcase different missing or wrong suggestions.

I left comments in each one of them for clarification, if it needs more details, please let me know.

The example repo, https://github.com/MenSeb/some-sass-bug, is up to date!

Previous issue: #190

  • VS Code version: 1.92.0
  • Extension version: 3.4.0
  • Operating system: Windows

P.S. Let me know if you prefer code examples directly here for future reference.

@wkillerud
Copy link
Owner

No need to be sorry, all of these tests and bug reports are super helpful 🥳 Linking to a repo with code examples works fine, no need to duplicate them in the issue 👍

@wkillerud
Copy link
Owner

wkillerud commented Aug 11, 2024

https://github.com/MenSeb/some-sass-bug/blob/1e85baf507cac5d1f22747ca68de385d9487f60b/src/test1.scss#L4

This was from a weirdness in the slightly-too-complicated completion context that made it so only variables got suggested after @debug. I tried simplifying a bit in 1159665 so now utils() gets suggested.

https://github.com/MenSeb/some-sass-bug/blob/1e85baf507cac5d1f22747ca68de385d9487f60b/src/test1.scss#L8-L9

Correct, it shouldn't suggest without prefix. Fixed in b65d8b1

Fixed in 3.5.0

@MenSeb
Copy link
Contributor Author

MenSeb commented Aug 12, 2024

Thanks @wkillerud it works well now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants