Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No GH actions CI run on PR #153

Open
reedy opened this issue Jan 3, 2025 · 1 comment
Open

No GH actions CI run on PR #153

reedy opened this issue Jan 3, 2025 · 1 comment

Comments

@reedy
Copy link
Contributor

reedy commented Jan 3, 2025 •
edited
Loading

Only on push?

Scrutinizer does seemingly run tests, but it's buried
@reedy reedy changed the title No useful CI run on PR No GH actions run on PR Jan 3, 2025
@reedy reedy changed the title No GH actions run on PR No GH actions CI run on PR Jan 3, 2025
@manicki
Copy link
Member

manicki commented Jan 6, 2025

oops, that's my bad. I believe I had skipped assuming you need to push in order to PR, so redundant, but this only holds if the PR contributor is able to push branches to this repository, which cannot be assumed.
Will fix.

manicki added a commit that referenced this issue Jan 6, 2025
@manicki
Run Lint and Test on PRs
b180484 
Addresses #153
@manicki manicki mentioned this issue Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reedy @manicki