Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Documentation #60

Open
yitzhakbg opened this issue Feb 21, 2020 · 3 comments
Open

Improve Documentation #60

yitzhakbg opened this issue Feb 21, 2020 · 3 comments

Comments

@yitzhakbg
Copy link

This is not so much a bug as it is a modest suggestion.
The documentation mentioned Configure Domains almost in passing. Should be more strongly emphasized. The .env file for example lists mariadb as here in it's definitions:
DB_NAME=wordpress
DB_USER=wordpress
DB_PASSWORD=wordpress
DB_ROOT_PASSWORD=password
DB_HOST=mariadb

without making clear that

mariadb

here is/should be a hostname. It is missing from the example:
image

@csandanov
Copy link
Member

Hi, mariadb is the name of the service in docker-compose.yml, docker uses services' names as hosts in its private network. In the table, we list only services with http ports so you can use them to access containers from the host machine. MariaDB has no http ports and you don't need any domain to connect WP internally with mariadb via $DB_PORT that should be used in wp-config.php

@yitzhakbg
Copy link
Author

Thanks. Could you make the documentation a tad clearer on that?

@csandanov
Copy link
Member

Not sure which part there's to improve, docker4wordpress assumes you're familiar with how docker and docker-compose work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants