Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOOOF Version #25

Open
TomDonoghue opened this issue Nov 19, 2019 · 2 comments
Open

FOOOF Version #25

TomDonoghue opened this issue Nov 19, 2019 · 2 comments

Comments

@TomDonoghue
Copy link

Hey Wonambi devs - I just wanted to let you know what quite soon a major new release version of FOOOF (1.0) will go live. This version does include some API breaking changes for some names, as we've worked to bring the API closer to the naming scheme we want to us. The underlying algorithm is basically the same, though 1.0 does also have some extra utilities.

I wanted to let you know since as it is, I believe wonambi is set up to use FOOOF 0.3.X, and once the version updates on PYPI, this is likely to stop working. You can of course set a specific version number in the fooof requirement if you want new installs to keep working as normal. And/or the naming changes aren't too many, so you could update wonambi to use the new API (which should be set in and stable from now on), and then set the required version number as 1.0. Let me know if you want any help with updating, etc.

@gpiantoni
Copy link
Member

Thanks a lot for your useful package and heads-up. I'm pinging @jnobyrne as he's been more involved in that part of the project. I agree with you that we should use the latest API if possible

@jnobyrne
Copy link
Contributor

Hi Tom, thanks for the heads up! We're big fans of the FOOOF toolbox, philosophy, and name. Given that the API changes are few should be stable from now on, I'd opt to update Wonambi to adapt to FOOOF 1.0. I see that the changes are on GitHub, so it should be pretty straightforward, but I'll let you know if I have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants