Bookable -> Accommodation product type switch, delete unused meta?

[tommyshellberg]

Affected ticket(s)

2134787-zen

What I expected

If I originally had a Bookable Product and switched to an Accommodation Product, I would expect that unused meta would at-least be ignored, if not deleted.

What happened instead

In this particular instance this user had a 1 day buffer period set when they switched to an Accommodation product. This piece of meta data not only persisted but was causing the checkout date to be unavailable.

Steps to reproduce the issue

You can inspect the meta for the product with this import file:
booking-product-210-2019-06-28.zip

To reproduce:

• Create a Bookable product with a 1 day buffer period and save.
• Switch to an Accommodation product and save.
• Pick a duration of dates using the Accommodation product calendar and checkout(Or just leave it in-cart and go back to the product page, same thing).

Image link: https://cld.wthms.co/z5tC9S

• Note how the checkout date is unavailable instead of available.

Image link: https://cld.wthms.co/OhBEiH

---

• Issue assigned to next milestone.
• Issue assigned a priority (will be assessed by maintainers).