From e854cab0f558c2c78add8d9044de39735842d04d Mon Sep 17 00:00:00 2001 From: Akshay Komar Date: Wed, 8 Jan 2025 23:53:56 +0530 Subject: [PATCH 1/2] Fix Spinner Ripple Effect in WCMaterialOutlinedSpinnerView Disabled Hint: Set hintEnabled="false" in the WCMaterialOutlinedSpinnerView style to prevent the floating hint from occupying space and causing unintended ripple effects in the layout. --- WooCommerce/src/main/res/values/styles_base.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/WooCommerce/src/main/res/values/styles_base.xml b/WooCommerce/src/main/res/values/styles_base.xml index 147aa52a894..0ad0839ac9e 100644 --- a/WooCommerce/src/main/res/values/styles_base.xml +++ b/WooCommerce/src/main/res/values/styles_base.xml @@ -388,6 +388,7 @@ theme across the entire app. Overridden versions should be added to the styles.x ?attr/selectableItemBackground true true + false From e0599ffe291311187efd139fad87c23984da5403 Mon Sep 17 00:00:00 2001 From: Akshay Komar Date: Fri, 10 Jan 2025 15:09:22 +0530 Subject: [PATCH 2/2] Fix: Apply custom ripple effect with padding --- .../src/main/res/drawable/custom_ripple.xml | 22 +++++++++++++++++++ .../src/main/res/values/styles_base.xml | 3 +-- 2 files changed, 23 insertions(+), 2 deletions(-) create mode 100644 WooCommerce/src/main/res/drawable/custom_ripple.xml diff --git a/WooCommerce/src/main/res/drawable/custom_ripple.xml b/WooCommerce/src/main/res/drawable/custom_ripple.xml new file mode 100644 index 00000000000..80bc78838d8 --- /dev/null +++ b/WooCommerce/src/main/res/drawable/custom_ripple.xml @@ -0,0 +1,22 @@ + + + + + + + + + + + + + + + + + + + + + + diff --git a/WooCommerce/src/main/res/values/styles_base.xml b/WooCommerce/src/main/res/values/styles_base.xml index 0ad0839ac9e..cde73b4e00d 100644 --- a/WooCommerce/src/main/res/values/styles_base.xml +++ b/WooCommerce/src/main/res/values/styles_base.xml @@ -385,10 +385,9 @@ theme across the entire app. Overridden versions should be added to the styles.x @color/color_on_surface_medium_selector src_atop false - ?attr/selectableItemBackground + @drawable/custom_ripple true true - false