Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Attribute Rename Validations Are Not Case Sensitive #12561

Closed
1 task
JorgeMucientes opened this issue Sep 9, 2024 · 1 comment · Fixed by #12608
Closed
1 task

Product Attribute Rename Validations Are Not Case Sensitive #12561

JorgeMucientes opened this issue Sep 9, 2024 · 1 comment · Fixed by #12608
Assignees
Labels
feature: product details Related to adding or editing products, includes product settings. type: bug A confirmed bug.

Comments

@JorgeMucientes
Copy link
Contributor

JorgeMucientes commented Sep 9, 2024

Describe the bug
A clear and concise description of what the bug is. Please be as descriptive as possible; issues lacking detail or for any other reason than to report a bug may be closed without action.

When renaming product attributes, we check if the name was edited. However, this check is not case-sensitive

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to rename a product attribute by just changing any number of characters from lower case to upper case.
  2. Then navigate back
  3. See a toast stating that the product attribute
  4. The product attribute won't be renamed and you'll have to remove it and add it again with the correct letter case. See screen recording for extra details.

Screenshots

CannotRename.mp4

Expected behavior

The product attribute name should be updated with the new lettercase.

Isolating the problem (mark completed items with an [x]):

  • I can reproduce this bug consistently using the steps above.

Mobile Environment
Please include:

  • Device: Pixel 8
  • Android version: 14
  • WooCommerce Android version: 20.2
@JorgeMucientes JorgeMucientes added type: bug A confirmed bug. feature: product details Related to adding or editing products, includes product settings. labels Sep 9, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product details Related to adding or editing products, includes product settings. type: bug A confirmed bug.
Projects
None yet
3 participants