Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coupons] Unify "Add coupon" button visibility in case order contains custom amount only #12848

Closed
samiuelson opened this issue Oct 30, 2024 · 3 comments
Assignees
Labels
feature: coupons Related to coupons for a store. priority: medium Planned tasks usually belonging to ongoing projects type: bug A confirmed bug.
Milestone

Comments

@samiuelson
Copy link
Contributor

samiuelson commented Oct 30, 2024

Discussion: https://wp.me/pdfdoF-5IP#comment-6772

Android and iOS apps are not consistent in the way we handle coupons. In case the order contains only a custom amount Android app allows adding a coupon to the order and iOS does not.

The goal of that issue is to make decision whether we should adjust Android app to follow the iOS implementation and update the conditions for showing the "Add coupon" button in the order creation screen.

@samiuelson samiuelson added type: bug A confirmed bug. feature: coupons Related to coupons for a store. labels Oct 30, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 30, 2024

Thanks for reporting! 👍

@malinajirka
Copy link
Contributor

I accidentally fixed this as part of this PR which was focused on bringing consistency to how the coupons are displayed in the order. I don't see a usecase in which someone would want to apply a coupon to an order which has only custom amount. Let's go with the iOS behavior for now and adjust if we here complains. This shouldn't block any users flows as they can always adjust the custom amount manually.

@malinajirka malinajirka self-assigned this Nov 6, 2024
@malinajirka malinajirka added the priority: medium Planned tasks usually belonging to ongoing projects label Nov 6, 2024
@malinajirka malinajirka added this to the 21.1 milestone Nov 6, 2024
@malinajirka
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: coupons Related to coupons for a store. priority: medium Planned tasks usually belonging to ongoing projects type: bug A confirmed bug.
Projects
None yet
Development

No branches or pull requests

3 participants