Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product: Error message is displayed when clearing all tags even though saving succeeds #14513

Closed
itsmeichigo opened this issue Nov 26, 2024 · 1 comment · Fixed by #14511
Closed
Assignees
Labels
feature: add/edit products Related to adding or editing products. priority: low Not many people are affected or there’s a workaround, etc.

Comments

@itsmeichigo
Copy link
Contributor

Describe the bug
When clearing all tags for a product, there's always an alert displayed saying the creation fails even though the saving succeeds.

To Reproduce
Steps to reproduce the behavior:

  1. Log in to a store.
  2. Create a new product or select an existing product.
  3. Add at least one tag to the product and save changes if the product doesn't have any tag yet.
  4. Reopen the tag list for the same product, clear all tags and tap Save.
  5. Notice that an error alert is displayed.
  6. Check the network request using Proxyman or Charles and confirm that the save request is completed without any error.

Screenshots
https://github.com/user-attachments/assets/7d47591a-2467-4488-bdad-a64e6bd6a9d8

Expected behavior
The error alert should not be displayed because the request did not fail.

@itsmeichigo itsmeichigo added feature: add/edit products Related to adding or editing products. priority: low Not many people are affected or there’s a workaround, etc. labels Nov 26, 2024
@dangermattic
Copy link
Collaborator

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: add/edit products Related to adding or editing products. priority: low Not many people are affected or there’s a workaround, etc.
Projects
None yet
2 participants