Add metric query endpoint #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodgern
reviewed
Nov 11, 2019
woodgern
reviewed
Nov 13, 2019
|
|
||
| println!("### QUERY: SELECT * FROM metrics {};", filter_clause); | ||
|
|
||
| let query_string = format!("SELECT * FROM metrics {} ORDER BY id LIMIT 10", filter_clause); |
There was a problem hiding this comment.
to test pagination, we can change it, nbd.
woodgern
reviewed
Nov 14, 2019
metrix/src/main.rs
Outdated
| if created_at_start_parsed.is_ok() { | ||
| filter_clause.insert_str( | ||
| filter_clause.len(), | ||
| &format!(" AND created_at > '{}'", created_at_start).to_string() |
There was a problem hiding this comment.
Might want >= here? Totally a 'product' thing, but I feel like 'start_date' is inclusive
woodgern
reviewed
Nov 14, 2019
metrix/src/main.rs
Outdated
| if created_at_end_parsed.is_ok() { | ||
| filter_clause.insert_str( | ||
| filter_clause.len(), | ||
| &format!(" AND created_at < '{}'", created_at_end).to_string() |
There was a problem hiding this comment.
Same here (not at all critical)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work items
offsetpagination (W E B S C A L E)start_datetime-end_datetime)Query format:
/metrics?offset=4&start_datetime=2019-11-11T01:10:00&end_datetime=2019-11-11T01:18:00It works with any combination of the 3 parameters.
Dev Notes (historical):
Originally tried to do dynamic query segments using the ORM using
BoxandBoxableExpressiontypes (see SO answer here).It was very complicated, but moreover we found out that json operators haven't yet been implemented for
dieselyet. See diesel-rs/diesel#44.So we instead are going with
sql_query(...)to generate a raw SQL query. Luckily diesel provides aQueryableByNameto still figure out the queried result can be directly instantiated into diesel Model types. 👌