Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining binary calls in MoneroDaemonRpc.js #1

Open
woodser opened this issue Aug 21, 2019 · 0 comments
Open

Implement remaining binary calls in MoneroDaemonRpc.js #1

woodser opened this issue Aug 21, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@woodser
Copy link
Owner

woodser commented Aug 21, 2019

The JavaScript client to daemon RPC already supports a number of binary calls. For example, getBlocksByHeight() uses the binary RPC call get_blocks_by_height.bin.

This issue requests support for the remaining unimplemented binary calls in MoneroDaemonRpc.js. Their implementation should follow the patterns of the already implemented binary calls, but may require additional processing like de-serializing some of the response fields which are also binary.

The remaining binary calls to be implemented are documented by the failing tests in TestMoneroDaemonRpc.js.

@woodser woodser added the help wanted Extra attention is needed label May 6, 2021
BeanTosser referenced this issue in BeanTosser/monero-javascript Aug 17, 2022
BeanTosser referenced this issue in BeanTosser/monero-javascript Aug 28, 2022
Add typescript support

Change TestSampleCode.ts to TestSampleCode.js to apply patch

Apply patch for Haveno daemon config

Rename TestSampleCode.js back to TestSampleCode.ts.

Fix duplicate merge conflict resolutions.

Fix models: if(value) -> if(value !== undefined).

Disaster recovery commit #1.

(not so) stable check-in.

Sanity check (in).

Add tons of debug logs.

Test hang error solved (at least without worker).

Various debug logs added and set proxyToWorker back to "false

Remove unused "babel-plugin-root-import"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant