From 8c6c4c7de9630f52635eb6a940f2adc396b16976 Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Mon, 13 Jan 2025 13:58:00 -0500 Subject: [PATCH] fix: Avoid unexpectedly marking post content as unsaved The custom `editorHasChanges` implementation resulted in an always-"dirty" state, even after saving changes via the "Update" or "Save draft" buttons. This removal, results in the editor relying upon the existing `editorHasChanges` implementation, which appears to be more accurate. https://github.com/wordpress-mobile/WordPress-iOS/blob/388dbb167b7ae6fd763ed4c90076dc94679a9dc6/WordPress/Classes/ViewRelated/Post/PostEditor.swift#L81-L83 --- .../NewGutenberg/NewGutenbergViewController.swift | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift b/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift index 7761ada2507a..c326d3ebeb96 100644 --- a/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift +++ b/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift @@ -70,18 +70,6 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor private let editorViewController: GutenbergKit.EditorViewController private weak var autosaveTimer: Timer? - var editorHasChanges: Bool { - var changes = post.changes - // TODO: cleanup (+ it doesn't handle scenarios like load from a revision) - // - warning: it has to compare two version serialized using the same system - if editorViewController.initialContent != post.content { - changes.content = post.content - } else { - changes.content = nil // yes, it needs to be set to .none manually - } - return !changes.isEmpty - } - // TODO: remove (none of these APIs are needed for the new editor) var autosaver = Autosaver(action: {}) func prepopulateMediaItems(_ media: [Media]) {}