From ca4794e64fe819acf35f9f3ffc192901b3b126ba Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Tue, 14 Jan 2025 13:27:19 -0500 Subject: [PATCH] fix: Avoid unexpectedly marking post content as unsaved (#23969) * fix: Avoid unexpectedly marking post content as unsaved The custom `editorHasChanges` implementation resulted in an always-"dirty" state, even after saving changes via the "Update" or "Save draft" buttons. This removal, results in the editor relying upon the existing `editorHasChanges` implementation, which appears to be more accurate. https://github.com/wordpress-mobile/WordPress-iOS/blob/388dbb167b7ae6fd763ed4c90076dc94679a9dc6/WordPress/Classes/ViewRelated/Post/PostEditor.swift#L81-L83 * docs: Add release note * docs: Fix release notes errors originating from rebasing --- RELEASE-NOTES.txt | 2 ++ .../NewGutenberg/NewGutenbergViewController.swift | 12 ------------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index fc1aa570950f..75e2226c4dc0 100644 --- a/RELEASE-NOTES.txt +++ b/RELEASE-NOTES.txt @@ -43,6 +43,8 @@ * [*] Fix an issue with fullscreen button in reply view clipped by the notch [#23965] * [*] Remove "Lazy Images" option that is no longer part of the Jetpack plugin [#23966] * [*] Fix an issue with "Speed up your site" section not refreshing (fails silently) [#23966] +* [**] Enable history navigation (undo and redo) for the experimental editor. [#23961] +* [*] Avoid unexpectedly marking post content as unsaved. [#23969] 25.6 ----- diff --git a/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift b/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift index 7761ada2507a..c326d3ebeb96 100644 --- a/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift +++ b/WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift @@ -70,18 +70,6 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor private let editorViewController: GutenbergKit.EditorViewController private weak var autosaveTimer: Timer? - var editorHasChanges: Bool { - var changes = post.changes - // TODO: cleanup (+ it doesn't handle scenarios like load from a revision) - // - warning: it has to compare two version serialized using the same system - if editorViewController.initialContent != post.content { - changes.content = post.content - } else { - changes.content = nil // yes, it needs to be set to .none manually - } - return !changes.isEmpty - } - // TODO: remove (none of these APIs are needed for the new editor) var autosaver = Autosaver(action: {}) func prepopulateMediaItems(_ media: [Media]) {}