Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for larger text sizes on the Traffic tab #22729

Closed
guarani opened this issue Feb 28, 2024 · 4 comments · Fixed by #22734
Closed

Improve support for larger text sizes on the Traffic tab #22729

guarani opened this issue Feb 28, 2024 · 4 comments · Fixed by #22734
Assignees

Comments

@guarani
Copy link
Contributor

guarani commented Feb 28, 2024

On the new Stats Traffic tab, larger text sizes result in a couple of issues:

  • the date picker strip doesn't increase in height (even as its contents do, resulting in clipped text)
  • the chart labels don't increase in font size
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 28, 2024

Thanks for reporting! 👍

@staskus
Copy link
Contributor

staskus commented Feb 29, 2024

the chart labels don't increase in font size

@guarani that was intentional since there's very little space to increase font sizes, especially on the horizontal axis. Also, if we allow to expansion of text on the vertical axis and shrink the chart, the horizontal axis would become even narrower. 🤔

Similar chart within Apple Health app doesn't increase bar chart font sizes as well:

Health.App.MP4

What we can allow without breaking the layout is a slight increase in font sizes when dynamic type changes.

@guarani
Copy link
Contributor Author

guarani commented Feb 29, 2024

I wondered about the possibility of making the y-axis labels go from:

200, 150, 100, 50, 0

to

200, 100, 0

to make room for the font size. Doing this on the x-axis wouldn't make much sense, though, so I think now it isn't a good idea to pursue.

Also, if we allow to expansion of text on the vertical axis and shrink the chart, the horizontal axis would become even narrower. 🤔

Similar chart within Apple Health app doesn't increase bar chart font sizes as well:

Good points!

What we can allow without breaking the layout is a slight increase in font sizes when dynamic type changes.

Ok, I'll check out the PR 🙇

@staskus
Copy link
Contributor

staskus commented Feb 29, 2024

I wondered about the possibility of making the y-axis labels go from <..> to make room for the font size

That's a good idea! 👍 Tried it here #22734 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants