From 5a0a2659627a187cea5934a9cc556b658f3de1ae Mon Sep 17 00:00:00 2001 From: SergioEstevao Date: Mon, 10 Sep 2018 13:14:21 +0100 Subject: [PATCH 1/2] Centralise propagation of changes on textViewDidChange delegate call. --- ios/RNTAztecView/RCTAztecView.swift | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ios/RNTAztecView/RCTAztecView.swift b/ios/RNTAztecView/RCTAztecView.swift index 46c19e0e3d..75c5eb93cd 100644 --- a/ios/RNTAztecView/RCTAztecView.swift +++ b/ios/RNTAztecView/RCTAztecView.swift @@ -69,17 +69,14 @@ class RCTAztecView: Aztec.TextView { super.insertText(text) updatePlaceholderVisibility() - - if let onChange = onChange { - let text = packForRN(getHTML(), withName: "text") - onChange(text) - } } open override func deleteBackward() { super.deleteBackward() updatePlaceholderVisibility() - + } + + func propagateContentChanges() { if let onChange = onChange { let text = packForRN(getHTML(), withName: "text") onChange(text) @@ -149,7 +146,6 @@ class RCTAztecView: Aztec.TextView { case "strikethrough": toggleStrikethrough(range: selectedRange) default: print("Format not recognized") } - propagateFormatChanges() } func propagateFormatChanges() { @@ -181,5 +177,10 @@ extension RCTAztecView: UITextViewDelegate { propagateFormatChanges() } + func textViewDidChange(_ textView: UITextView) { + propagateFormatChanges() + propagateContentChanges() + } + } From bf62df716554a037b66f19a6fd1c2ff2c603d7f1 Mon Sep 17 00:00:00 2001 From: SergioEstevao Date: Mon, 10 Sep 2018 13:14:32 +0100 Subject: [PATCH 2/2] Remove log message. --- ios/RNTAztecView/RCTAztecViewManager.m | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ios/RNTAztecView/RCTAztecViewManager.m b/ios/RNTAztecView/RCTAztecViewManager.m index c55c929e70..5bfc29117a 100644 --- a/ios/RNTAztecView/RCTAztecViewManager.m +++ b/ios/RNTAztecView/RCTAztecViewManager.m @@ -33,8 +33,7 @@ - (void)executeBlock:(ActionBlock)block onNode:(NSNumber *)node { } RCT_EXPORT_METHOD(applyFormat:(nonnull NSNumber *)node format:(NSString *)format) -{ - RCTLogInfo(@"Apply format: %@", format); +{ [self executeBlock:^(RCTAztecView *aztecView) { [aztecView applyWithFormat:format]; } onNode:node];