Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the way we determine how a post has been edited #252

Closed
wants to merge 2 commits into from
Closed

Update the way we determine how a post has been edited #252

wants to merge 2 commits into from

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Nov 16, 2018 •
edited
Loading

Fixes #227
Fixes #266

This PR uses the isEditedPostDirty selector from the core/editor store to determine if a post was edited or not and needs to be saved on the server.

Testing instructions

  • Run the project from WordPress-Android feature/gutenberg-mobile branch:
    • git checkout feature/gutenberg-mobile
    • git submodule update --init
    • cd libs libs/gutenberg-mobile
    • git fetch -a && git checkout update/compare-html
    • git submodule update --init
    • yarn install
    • Start an AVD or connect a physical Android device in debug mode
    • yarn wpandroid
  • Click on a page to edit, close
  • Page shouldn't appear as being modified
  • If you navigate to http://localhost:8081/debugger-ui/ and enable debugging in the Android app, you should see the isEditedPostDirty false in the console
  • Click on a page to edit, edit the content
  • Page should appear as being modified
  • you should see the isEditedPostDirty true in the console

@Tug Tug self-assigned this Nov 16, 2018
@Tug Tug force-pushed the update/compare-html branch 3 times, most recently from b0025d4 to 457230b Compare November 19, 2018 07:47
@Tug Tug requested a review from hypest November 19, 2018 08:55
This was referenced Nov 20, 2018
Closed
Merged
@Tug Tug force-pushed the update/compare-html branch from 457230b to 7f9f8e6 Compare November 20, 2018 16:07
@hypest
Copy link
Contributor

hypest commented Nov 21, 2018

As mentioned over Slack too, it seems that some posts still manage to trigger the dirtiness flag when exiting the editor so, additional investigation/solution is needed to avoid having the editor report self-inflicted "dirtiness".

@hypest
Copy link
Contributor

hypest commented Nov 28, 2018

Is this PR still relevant/active? Can we close it if not? Thanks!

@Tug Tug force-pushed the update/compare-html branch from 7f9f8e6 to 674ff00 Compare December 4, 2018 09:52
@koke koke changed the base branch from master to develop December 21, 2018 09:21
@koke
Copy link
Member

koke commented Dec 21, 2018

I've changed the target branch to develop, which is right now the same commit as master, so there shouldn't be any issue

@koke
Copy link
Member

koke commented May 6, 2019

I'm guessing this might be obsolete, or will be with the BlockList refactor. Should we close it?

@hypest
Copy link
Contributor

hypest commented Jul 4, 2019

With the BlockList refactor already well progressed, is this PR still relevant @Tug ?

@Tug
Copy link
Contributor Author

Tug commented Jul 9, 2019

Closing as it looks obsolete now

@Tug Tug closed this Jul 9, 2019
@Tug Tug deleted the update/compare-html branch July 9, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest Awaiting requested review from hypest

Assignees

@Tug Tug

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Tug @hypest @koke