Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add/upload images if Don't keep activities is ON #582

Open
daniloercoli opened this issue Feb 8, 2019 · 7 comments
Open

Unable to add/upload images if Don't keep activities is ON #582

daniloercoli opened this issue Feb 8, 2019 · 7 comments
Assignees
Labels
Media [OS] Android Parent app An issue that happens outside the editor and its RN bridge. Better move to main app repo. [Type] Bug Something isn't working

Comments

@daniloercoli
Copy link
Contributor

Image uploading isn't work fine on Android if Don't keep activities is turned ON.

To reproduce this problem

  • Start the wp-android app
  • Tap on the button to add a new post
  • Add an Image block
  • Select a picture from the device
  • Once the picture is selected you're back to the post with the Image block placeholder

(Not sure if the upload is going on under the hood or not).

@daniloercoli daniloercoli added [Type] Bug Something isn't working Media labels Feb 8, 2019
@hypest
Copy link
Contributor

hypest commented Feb 11, 2019

  • Add an Image block

Just making sure, is this a Gutenberg only issue or does it happen in Aztec too @daniloercoli ?

@daniloercoli
Copy link
Contributor Author

It does work without any problem on Aztec. (Tested on alpha-150 - versionCode 674)

@SergioEstevao SergioEstevao added [OS] Android Parent app An issue that happens outside the editor and its RN bridge. Better move to main app repo. labels May 4, 2020
@SergioEstevao SergioEstevao changed the title [Android] Unable to add/upload images if Don't keep activities is ON Unable to add/upload images if Don't keep activities is ON May 4, 2020
@SergioEstevao
Copy link
Contributor

@mchowning is this still happening on Android?

@mchowning
Copy link
Contributor

mchowning commented May 4, 2020

I am still seeing this issue, although it presents slightly differently now. After selecting to upload the image, I see the in progress upload icon in the notification bar and the upload does complete successfully, but the image block never gets updated and still has the image placeholder.

@SiobhyB SiobhyB self-assigned this Feb 7, 2022
@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 7, 2022

Noting that I'm going to be taking a dive into this issue. :)

I'm still seeing the same behaviour that Matt detailed with Don't keep activities enabled. You'll see from the following video that the the Image block isn't correctly updated although the uploaded image is correctly added to the site's Media Library:

image.mov

The above video comes from testing on the latest alpha-341 on a Pixel 4XL emulator. I also confirmed the same behaviour on a physical Pixel 5 on version 19.1 of the app.

Related issues:

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 10, 2022

I chatted with @hypest about this issue a bit yesterday, he let me know that the fix for this issue is likely not simple, possibly requiring larger architectural considerations that are a bit beyond the scope of what we're currently trying to achieve. I time-boxed some explorations and confirmed I wasn't able to make progress on a fix. Given that, and the fact this issue isn't impacting a large number of users, I'm un-assigning myself for now.

While researching this issue, I came across this work from other developers that may be helpful for people looking into this in the future:

@SiobhyB SiobhyB removed their assignment Feb 10, 2022
@mchowning mchowning self-assigned this Feb 17, 2022
@mchowning
Copy link
Contributor

mchowning commented Feb 17, 2022

In my testing, with Don't keep activities enabled, any time I attempt to insert an image (whether it is an uploaded image, or from the media gallery), the post fails to actually update with the inserted image (i.e., the block remains empty), so this appears to be a broader issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media [OS] Android Parent app An issue that happens outside the editor and its RN bridge. Better move to main app repo. [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants