Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad: "Choose image" popover moves around when rotating device #724

Open
rachelmcr opened this issue Mar 8, 2019 · 1 comment
Open

iPad: "Choose image" popover moves around when rotating device #724

rachelmcr opened this issue Mar 8, 2019 · 1 comment
Labels
[OS] iOS [Pri] Low [Type] Enhancement Improves a current area of the editor

Comments

@rachelmcr
Copy link
Contributor

When I add an image block, there's a "Choose Image" button. On Android and iPhone that brings up an action sheet, but on iPad it brings up an action popover. That popover moves around on the screen when I rotate my device between portrait and landscape.

Screencast: https://cloudup.com/cRavA8Zdr_N

@etoledom suggested that the popover should probably stay near the button, maybe with a little arrow. One example of that is the popover in WPiOS when you exit the editor after making changes:

photo 08-03-2019 15 48 06

@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label May 4, 2020
@SergioEstevao
Copy link
Contributor

At the moment we are just centering the alert on the middle of the screen. When the device is rotated we don't update the position to the center of the new layout.

To implement the arrow, like in the image above, we will need to have a way to detect what is the current view that is selected in the JS/RN side and keep a track of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] iOS [Pri] Low [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

No branches or pull requests

2 participants