Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and suggestions #3

Open
acidjunk opened this issue Dec 11, 2023 · 1 comment
Open

Docs and suggestions #3

acidjunk opened this issue Dec 11, 2023 · 1 comment

Comments

@acidjunk
Copy link
Collaborator

acidjunk commented Dec 11, 2023

Not sure if this project is meant to be used as a starter for a workflow based project?

1
It's a nice and simple project layout; but I suppose that quit some refactoring is needed when you want to use this.
For SURF orchestrators we use a folder layout that puts the webserver in it's own folder; which gives you more room on the root level, to add a folder tests, some helm charts, docs etc.

Probably good to be a bit opinionated as this will make support easier.

2
Without tests, or a pipeline it's a bit hard to find out how to get this running.
Probably something like this in the Readme?

Quick install

create a venv, then run these commands:

pip install -r requirements.txt
python main.py db upgrade heads
python -u -m uvicorn --reload --workers 4 --host 0.0.0.0 --port 8080 main:app

This assumes a env that has correct settings or it will use the orchestrator-core defaults (like DB name orchestratorc-core).

@Sparrow1029
Copy link

I'd also suggest that the docs need updating for orchestrator-core-gui v2, and I second more docs about how to run locally 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants