CLIAR milestones

[galileukim]

• summary of how data update was executed in 2024 (Ileana, Ify).
• reproducibility package (Ileana, Ify, Awais, Gali).
• inclusion of b-ready indicators (TBD).
• include revised CLIAR figure in the automatic ppts and word (Kannan).
• bivariate correlation, change the year from 2022 to 2023 (logged GDP).
• add an advanced report button in the Country Benchmarking tab (Kannan).
• create a data export button for the graph in the Bivariate Correlation tab (Kannan).
• ensure that captions for the graphs are complete (Kannan).

[kannanv93]

Thanks Gali, Will update changes by Monday

[kannanv93]

Data export button for the graph - Complete

[kannanv93]

@galileukim < add an advanced report button in the Country Benchmarking tab (Kannan).>
We currently have an option to select the tick box and download editable report, this will produce the advanced report. Do we still need a separate button ?

[kannanv93]

@galileukim : Regd. bivariate correlation, change the year from 2022 to 2023 (log GDP). Is it a data change or just a change on UI ?

[ileanamarroquin]

@galileukim : Regd. bivariate correlation, change the year from 2022 to 2023 (log GDP). Is it a data change or just a change on UI ?

@kannanv93: I'm following up this comment you mentioned @galileukim because the footnote issue is more complex than just adding an if condition, I first want to make sure that the log GDP variable specification is the correct one.

Here's an example with some issues to discuss:

1. Footnote Content: The footnote currently only displays the description of the independent variable (x-axis). Should we keep it this way? I've attached an image for reference:
   

2. Outdated Footnote Description: The footnote description is extracted from the Description variable in the db_variables file. However, for the specific case of the log GDP variable (wdi_nygdppcapppkd), the description is outdated. It currently states a base year of 2017, while in reality, the base year is 2021 (I've personally verified this). We should correct this description and potentially others in the db_variables file.

3. Average of logGDP Variable: According to the \code\05-ctf.Rmd script, there's a comment specifying a specific methodology that requires a 5-year average for the log GDP variable. Here are the relevant code lines:
   

My concern is twofold:

a) Is this 5-year average exported as part of the db_variables file?
b) Is this 5-year average used when generating the plot using the functions from the auxiliary functions in the plots.R script? Here's the relevant code snippet:

Based on this code, it seems like the current plot might not be using an average and is potentially only considering the last year of observation. I could be wrong, but I'd like to confirm this with @kannanv93 who knows the app part better. If this is the case, we can eliminate this concern and implement the if condition in the function for users selecting the log GDP for the graph.

[kannanv93]

1. @ileanamarroquin Fixed the 1st issue. The note had info of both x and y axis but because of the margins, the note was getting cut. I have fixed this issue
2. Yes, changing the var_name and description in db_variables will solve this issue.
   Also the reason why this discrepancy exists is because we had original WDI data which used 2017 and in October we shifted to new WDI data were 2021 was used.
3. Yes, for GDP, our current process takes average across all other variables but for GDP, we had used year 2023. This code is also from 05-CTF- Line 150. I think we should remove this filter, not sure why this was the case at first place