Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients/js: add tests #2596

Open
heyitaki opened this issue Apr 7, 2023 · 3 comments
Open

clients/js: add tests #2596

heyitaki opened this issue Apr 7, 2023 · 3 comments
Assignees
@AlberErre
Milestone
Maintenance - Til...

Comments

@heyitaki
Copy link
Contributor

heyitaki commented Apr 7, 2023

Currently, most if not all of the code in clients/js has no tests. We should add tests for each command to ensure future refactors don't break any functionality.
@aadam-10 aadam-10 added this to the Maintenance - Tilt / CLI milestone Apr 10, 2023
@AlberErre
Copy link
Contributor

AlberErre commented Apr 10, 2023 •
edited
Loading

@heyitaki after playing around with the previous issue (#2598), I feel confident enough to jump on testing 🙌

could you assign me this issue as well? 👀

@AlberErre AlberErre mentioned this issue Apr 13, 2023
Closed
@AlberErre
Copy link
Contributor

@heyitaki @kcsongor I've added some testing for the worm CLI 🎉

Here is the PR ✅ -> #2631

@AlberErre AlberErre mentioned this issue Jul 23, 2023
Closed
@AlberErre
Copy link
Contributor

A new PR (also covering worm submit test cases) has been added here: #3229 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlberErre AlberErre

Labels
None yet
Projects
None yet
Milestone
Maintenance - Tilt / CLI
3 participants
@heyitaki @AlberErre @aadam-10