Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation Failure Due to SPL Token Metadata Size Update #4138

Open
tokenwrap opened this issue Oct 15, 2024 · 1 comment
Open

Attestation Failure Due to SPL Token Metadata Size Update #4138

tokenwrap opened this issue Oct 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tokenwrap
Copy link

Description and context
I'm encountering an issue where attestation is failing for SOL-ETH tokens minted by Pumpfun using the Wormhole SDK. This seems to be due to recent changes in the SPL token metadata.

Problem
Attestation is failing for tokens created recently. The issue arises because Metaplex resized the SPL token metadata account from 679 bytes to 607 bytes (commit 6b2e869). However, the token-bridge is still validating based on the older size, causing the attestation to fail for tokens with the new metadata accounts. Relevant link: Metaplex Token Metadata Account Size Reduction Guide.

Steps to reproduce
Attempt to bridge SOL-ETH tokens minted by Pumpfun via the Wormhole SDK.
Execute the transaction on the Solana network.
Transaction fails during metadata validation.
Experienced behavior
The transaction fails because the token-bridge is validating SPL token metadata using the older size constant.

Expected behavior
Tokens should bridge successfully, with metadata validation accounting for both the
old and new SPL token metadata account sizes.

Solution recommendation
A potential fix probably here (solana/modules/token_bridge/program/src/accounts.rs) would be to either update the token-bridge to recognize the new metadata account size or add a condition that validates tokens with both the old and new sizes.

@tokenwrap tokenwrap added the bug Something isn't working label Oct 15, 2024
@tokenwrap
Copy link
Author

We also made a PR: #4132
but you guys can fix the way you prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant