3.19 - Preload Fonts - User Interface part

[piotrbak]

User Story
As an admin, I want to see the new UI of preload fonts so that I can enable the feature

Acceptance Criteria

• A checkbox should be added to enable the feature on release under Media > Fonts with text mentioned [here](https://www.notion.so/Preload-fonts-126ed22a22f0808ba45ad3673c2c176b?pvs=21)
• The checkbox is not checked by default for fresh install
• Need Help of fonts will need to point to the different doc
• Move the section description under the Self-host Google Fonts checkbox

[Miraeld]

Scope a solution

About the setting page layout,
We need to move this to this block so the section description will be moved under the self-host checkbox.

Then to create a new checkbox:
add the following:

'auto_preload_fonts'       => [
	'type'              => 'checkbox',
	'label'             => __( 'Preload Fonts', 'rocket' ),
	'section'           => 'font_optimization_section',
	'page'              => 'media',
	'default'           => 0,
	'sanitize_callback' => 'sanitize_checkbox',
],

before this.

In case we need to hide the preload_fonts field:
Add preload_fonts to this

wp-rocket/inc/Engine/Admin/Settings/Page.php

Line 2098 in 3a73b77

$hidden_fields = [

list.

Then, on WP Rocket upgrade, if preload_fonts was enable, we would like to have the new option enabled. For this,
In this class https://github.com/wp-media/wp-rocket/blob/3a73b77cf8ba024601cf07c4341497975d459847/inc/Engine/Admin/Settings/Subscriber.php we need to add a callback on wp_rocket_upgrade , it could be maybe_enable_auto_preload_fonts and it would check the current value of preload_fonts to enable or not auto_preload_fonts.

---

However, @piotrbak I don't see in the notion any mention of the description of this new checkbox. I can see there is one on this screenshot: https://www.notion.so/wpmedia/Preload-fonts-126ed22a22f0808ba45ad3673c2c176b?pvs=4#17ced22a22f08080a661d0c15b0c75d6
but where does the more info point + where does the need help should point ?

[piotrbak]

@Miraeld Pinged Cami about the docs, we should get the answer very soon. If not, we can create a subtask in order not to block the issue and not to forget about it

[jeawhanlee]

@piotrbak if preload fonts fields was not empty after update this would be checked automatically right?

[piotrbak]

Yes, that's a part of the different story. But can be included here if that's a very quick one

[jeawhanlee]

I don't think we will be using the same id as the preload_fonts because we already using this and it returns an array at the moment, I think we can use something different maybe auto_preload_fonts then when we get to the story that considers the old option during upgrade we can change this.

cc @wordpressfan

[wordpressfan]

Totally agree with @jeawhanlee we need to name it differently, auto_preload_fonts is a good name.
Also plz note that if we removed preload_fonts from the list of settings, I think once we update, this option will be removed, so we need to validate this and if needed we may add it to hidden settings, to have it in exported settings file, this will be helpful if the user wanted to rollback and need to export settings before that.

[jeawhanlee]

@Miraeld can you update the grooming to reflect this? Thanks

[Miraeld]

@jeawhanlee @wordpressfan I've updated the grooming

[jeawhanlee]

Then, on WP Rocket upgrade, if preload_fonts was enable, we would like to have the new option enabled. For this,
In this class https://github.com/wp-media/wp-rocket/blob/3a73b77cf8ba024601cf07c4341497975d459847/inc/Engine/Admin/Settings/Subscriber.php we need to add a callback on wp_rocket_upgrade , it could be maybe_enable_auto_preload_fonts and it would check the current value of preload_fonts to enable or not auto_preload_fonts.

@Miraeld We will not handle that in this task as we have it in another according to @piotrbak here so we can take it out of the grooming.

Other than that LGTM, once grooming is updated, you can move it to ToDo. Thanks

[Miraeld]

@jeawhanlee as Piotr said

But can be included here if that's a very quick one

It is a quick one in a way, it could be included here. Don't you think ?

[jeawhanlee]

Ok, Then