Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #7242 3.19 - Preload Fonts - Data insertion part #7274

Open
wants to merge 5 commits into
base: feature/preload-fonts
Choose a base branch
from
Open

Closes #7242 3.19 - Preload Fonts - Data insertion part #7274

wants to merge 5 commits into from
+1,012 −4

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Feb 4, 2025 •
edited
Loading

Description

Add database structure and ajax for preload fonts
Fixes #7242

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

N/A

Technical description

Documentation

Add 3.19 database structure, ajax controller.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Khadreal Khadreal changed the base branch from develop to feature/preload-fonts February 4, 2025 07:50
@codacy-production Codacy Production
Copy link

codacy-production bot commented Feb 4, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.12% (target: -0.10%) ✅ 51.06% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5b018e4) 38787 17157 44.23%
Head commit (e46f9b5) 38881 (+94) 17247 (+90) 44.36% (+0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7274) 94 48 51.06%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Khadreal Khadreal marked this pull request as ready for review February 5, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.19 - Preload Fonts - Data insertion part
1 participant
@Khadreal