Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.19 - Preload Fonts - Data Clearance #7244

Open
piotrbak opened this issue Jan 26, 2025 · 6 comments
Open

3.19 - Preload Fonts - Data Clearance #7244

piotrbak opened this issue Jan 26, 2025 · 6 comments
Milestone

Comments

@piotrbak
Copy link
Contributor

User Story
As a user, I want to clear preload fonts with the same actions as priority elements

Acceptance Criteria

  • Full clear when
    • Clear priority elements from admin
    • Switch theme
    • Change permalinks
    • Domain change
  • Partial clear when
    • Clear priority elements of this URL
    • Add/edit/delete post
    • Update comments count
@piotrbak piotrbak added this to the 3.19-prealpha milestone Jan 26, 2025
@Khadreal
Copy link
Contributor

Scope a solution ✅

  • Hook a callback to switch_theme, permalink_structure_changed, rocket_domain_options_changed, rocket_after_clean_domain
  • To clear priority elements of this URL, we should create a Factory class for Fonts similar to this and add the factory container to this
    and hook a callback to delete_post, wp_update_comment_count, wp_trash_post, clean_post_cache
  • Add test

Estimation
[S]

@jeawhanlee
Copy link
Contributor

Good job @Khadreal

Although, From my point of view, I do't see us implementing anything in this task because we have shared admin subscriber for all performance hints features here which handles clearing in it as well. so by default this task should be settled when we implement this for db handling.

cc @wordpressfan

@Khadreal
Copy link
Contributor

Khadreal commented Feb 3, 2025

Should this be move back to need grooming ? cc @jeawhanlee

@jeawhanlee
Copy link
Contributor

I don't think so, pinging @MathieuLamiot for direction.

@MathieuLamiot
Copy link
Contributor

Same as #7250

@jeawhanlee
Copy link
Contributor

This issue can be tested when this is implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants