Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.19 - Preconnect to external domains - Data insertion part #7248

Open
piotrbak opened this issue Jan 26, 2025 · 2 comments
Open

3.19 - Preconnect to external domains - Data insertion part #7248

piotrbak opened this issue Jan 26, 2025 · 2 comments
Milestone

Comments

@piotrbak
Copy link
Contributor

User Story
As a user, I want to see the eligible external domains in the database when manually visiting a page

Acceptance Criteria

  • The table is created with a fresh install and with an update
  • These data are stored in DB when visiting the uncached page while nothing in DB (to be adjusted)
    • URL, ID, device type, status, error message
    • Eligible domain name
  • Any possible error will be saved into the DB and status set to failed
  • If no proper connections are found, we’ll save this fact to the database and set the status to completed
@piotrbak piotrbak added this to the 3.19-prealpha milestone Jan 26, 2025
@wordpressfan
Copy link
Contributor

@jeawhanlee
Copy link
Contributor

Scope a solution ✅

  • Create the database modules for the PreconnectExternalDomains namespace if not created, the same way we do for the other performance hints features, for example here
    • Queries
    • Rows
    • Schemas
    • Tables
  • Use this for the schema
  • Create the ajax Controller in the AJAX namespace. The controller will implement WP_Rocket\Engine\Common\PerformanceHints\AJAX\ControllerInterface
  • Add the must-implement methods( add_data & check_data ). Add the logic to process data in both methods.
  • Update or Add ServiceProvider if not created.
  • Add tests

Estimate the effort ✅

[S]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants