Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstring of wt.kit.fluence is not accurate. #1029

Open
darienmorrow opened this issue Oct 22, 2021 · 1 comment
Open

Docstring of wt.kit.fluence is not accurate. #1029

darienmorrow opened this issue Oct 22, 2021 · 1 comment

Comments

@darienmorrow
Copy link
Member

WrightTools/WrightTools/kit/_calculate.py

Line 20 in b1b3017

def fluence(

  • Add beam_radius_type kwarg. Default should be HWHM. Add w0 too.
  • Update docstring to be reflective of achieved calculation.
  • $w_0 = 2\sigma = 0.8493*FWHM$
@jsunny17
Copy link

Hi,
I am starting up on easier code issues as a learning step. What do you mean by w0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darienmorrow @jsunny17