Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contourf needs testing with new quick2D #1191

Open
ddkohler opened this issue Oct 15, 2024 · 2 comments
Open

contourf needs testing with new quick2D #1191

ddkohler opened this issue Oct 15, 2024 · 2 comments

Comments

@ddkohler
Copy link
Contributor

ddkohler commented Oct 15, 2024

if plot_type == "contourf":
if "levels" not in kwargs.keys():
kwargs["levels"] = np.linspace(kwargs["vmin"], kwargs["vmax"], 256)

when pixelated = False, this clause can run without "vmin" kwarg existing (per James)

@ddkohler
Copy link
Contributor Author

I believe the fix is just changing kwargs["vmin"] and kwargs["vmax"] to vmin and vmax

We should make a test for this.

@ddkohler
Copy link
Contributor Author

upon more inspection, it looks like this is one of the growing pains of our switch to using norm arguments around v3.5.1

using versions before this does not cause this error (James has verified)

I think these problem clauses need to screen for, and handle, norm in the kwargs, but it's clear testing should be incorporated to make the contourf/contour implementations robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant