Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra URL validations in "siddhi-io-cdc" extension. #1062

Open
janithcmw opened this issue Feb 26, 2020 · 0 comments
Open

Remove extra URL validations in "siddhi-io-cdc" extension. #1062

janithcmw opened this issue Feb 26, 2020 · 0 comments

Comments

@janithcmw
Copy link

janithcmw commented Feb 26, 2020

In the current implementation, a REGX pattern[1] is used to validate and extract the URL(hostname) of the database server in the "siddhi-io-cdc" extension.
Due to the validation of the current REGX, some validate URL also get rejected contains "." and "-". Let's improve REGX pattern validation.
[1] https://github.com/janithcmw/siddhi-io-cdc-public/blob/dc7fba1a7241a43d7e57fcfe52bcbd0330b15946/component/src/main/java/org/wso2/extension/siddhi/io/cdc/util/CDCSourceUtil.java#L55-L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant