You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Data often need to be interpolated to a particular grid, usually in temperature space. Initially, I used interp1d for everything, but that function is now considered "legacy" and thus should be avoided.
Additionally, for reasons explained more fully in #223, I've used a PCHIP interpolation method in log-log space for particular pieces of data.
We need to come up with a policy for which interpolation method we use by default and stick to a single method unless there is a compelling reason to deviate from that method. Once a decision is made, this should probably be put in the docs somewhere.
A rough plan of work for addressing this:
Decide whether CubicSpline or PCHIPInterpolator is a more appropriate general solution
Replace all interp1d calls with the decision from 1
Document this decision somewhere, maybe a dev guide?
The text was updated successfully, but these errors were encountered:
I changed the title a bit to reflect that I don't think there is a one-size fits all solution to this problem. We should instead provide some brief guidance on which method to choose. This could be a topic guide in the docs.
Data often need to be interpolated to a particular grid, usually in temperature space. Initially, I used
interp1d
for everything, but that function is now considered "legacy" and thus should be avoided.Additionally, for reasons explained more fully in #223, I've used a PCHIP interpolation method in log-log space for particular pieces of data.
Now, in #260,
CubicSpline
is being used.We need to come up with a policy for which interpolation method we use by default and stick to a single method unless there is a compelling reason to deviate from that method. Once a decision is made, this should probably be put in the docs somewhere.
A rough plan of work for addressing this:
CubicSpline
orPCHIPInterpolator
is a more appropriate general solutioninterp1d
calls with the decision from 1The text was updated successfully, but these errors were encountered: