Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use io.Reader #1

Open
rwcarlsen opened this issue Jan 9, 2013 · 3 comments
Open

Use io.Reader #1

rwcarlsen opened this issue Jan 9, 2013 · 3 comments

Comments

@rwcarlsen
Copy link

Using the Go stdlib io.Reader interface instead of just file opening would make this package more flexible and more idiomatic.

@wtolson
Copy link
Owner

wtolson commented Apr 10, 2015

I agree, but not sure how you would go about it as the underlying taglib api only reads from disk. It could write the io.Reader to a temp file to give to taglib but would have great performance characteristics. Any thoughts on how to do this in an efficient manner?

@rwcarlsen
Copy link
Author

Hm - probably not worth the trouble then. You could rewrite taglib in go :P

On Fri, Apr 10, 2015 at 11:56 AM, Trevor [email protected] wrote:

I agree, but not sure how you would go about it as the underlying taglib
api only reads from disk. It could write the io.Reader to a temp file to
give to taglib but would have great performance characteristics. Any
thoughts on how to do this in an efficient manner?


Reply to this email directly or view it on GitHub
#1 (comment).

@GwynethLlewelyn
Copy link

Hm - probably not worth the trouble then. You could rewrite taglib in go :P

Now that would be the thing!! 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants