Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc vars #130

Closed
lee1043 opened this issue Oct 18, 2021 · 1 comment · Fixed by #139
Closed

Update doc vars #130

lee1043 opened this issue Oct 18, 2021 · 1 comment · Fixed by #139
Assignees
@tomvothecoder
Labels
type: docs Updates to documentation

Comments

@lee1043
Copy link
Collaborator

lee1043 commented Oct 18, 2021

Describe your documentation update

In this example for the spatial average, variable tas is used for deriving Nino 3.4 index. However in CMIP, the variable name tas has been indicating near surface (2-m) temperature, I think it would make more sense to use ts variable instead, which is for surface temperature (thus considered as sea-surface temperature over ocean).

I suggest replacing tas by ts.
@lee1043 lee1043 added the type: docs Updates to documentation label Oct 18, 2021
@tomvothecoder tomvothecoder self-assigned this Oct 19, 2021
@tomvothecoder
Copy link
Collaborator

Another doc caught in xCDAT/xcdat-validation#27 to be done with this issue:
data_var should replace keep_var

@tomvothecoder tomvothecoder changed the title Doc update for spatial avg Update doc vars Nov 1, 2021
@tomvothecoder tomvothecoder mentioned this issue Nov 9, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomvothecoder tomvothecoder

Labels
type: docs Updates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update HISTORY.rst and fix docstrings xCDAT/xcdat
2 participants
@lee1043 @tomvothecoder