Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win10x64 crash while extracting #37

Open
githuborer opened this issue Dec 27, 2019 · 4 comments
Open

Win10x64 crash while extracting #37

githuborer opened this issue Dec 27, 2019 · 4 comments

Comments

@githuborer
Copy link

This addon crashes Kodi badly every time I want to extract roms launched by IAGL or scan library and have some archives in it.

@AlwinEsch
Copy link
Member

Have you a example files of roms to test and fix it?

@githuborer
Copy link
Author

For example any zipped file over "Internet Archive Best Of - N64" list with:
<emu_postdlaction>unzip_rom</emu_postdlaction>
Or from "Internet Archive Best Of - PS1" list with:
<emu_postdlaction>unarchive_game_launch_cue</emu_postdlaction>

After download zip file it crashes cos of postdlaction.

You could also try a zipped movie file and start scrapping for Kodi library.

@zach-morris
Copy link
Contributor

zach-morris commented Feb 29, 2020

I can confirm this does crash on windows10x64 specifically with 7z files. You can use the small test plugin I created in this issue to test and recreate:
#31

https://github.com/xbmc/vfs.libarchive/files/3682637/plugin.program.archivetest.zip

Log from windows as follows:

2020-02-28 16:43:06.046 T:4076  NOTICE: Archive Test Tool:  Tool Started
2020-02-28 16:43:06.047 T:4076   DEBUG: Testing C:\Users\Z\AppData\Roaming\Kodi\addons\plugin.program.archivetest\resources\test.zip
2020-02-28 16:43:06.049 T:4076   DEBUG: Created folder C:\Users\Z\AppData\Roaming\Kodi\addons\plugin.program.archivetest\resources\test_zip\test\ for archive C:\Users\Z\AppData\Roaming\Kodi\addons\plugin.program.archivetest\resources\test.zip
2020-02-28 16:43:06.054 T:4076   DEBUG: Extracted file test1.txt from archive archive://C%3A%5CUsers%5CZ%5CAppData%5CRoaming%5CKodi%5Caddons%5Cplugin.program.archivetest%5Cresources%5Ctest.zip/test/
2020-02-28 16:43:06.056 T:4076   DEBUG: Extracted file test2.txt from archive archive://C%3A%5CUsers%5CZ%5CAppData%5CRoaming%5CKodi%5Caddons%5Cplugin.program.archivetest%5Cresources%5Ctest.zip/test/
2020-02-28 16:43:06.056 T:4076   DEBUG: Created folder C:\Users\Z\AppData\Roaming\Kodi\addons\plugin.program.archivetest\resources\test_zip\test\test2\ for archive archive://C%3A%5CUsers%5CZ%5CAppData%5CRoaming%5CKodi%5Caddons%5Cplugin.program.archivetest%5Cresources%5Ctest.zip/test/
2020-02-28 16:43:06.058 T:4076   DEBUG: Extracted file test3.txt from archive archive://C%3A%5CUsers%5CZ%5CAppData%5CRoaming%5CKodi%5Caddons%5Cplugin.program.archivetest%5Cresources%5Ctest.zip/test/test2/
2020-02-28 16:43:06.060 T:4076   DEBUG: Extracted file test4.txt from archive archive://C%3A%5CUsers%5CZ%5CAppData%5CRoaming%5CKodi%5Caddons%5Cplugin.program.archivetest%5Cresources%5Ctest.zip/test/test2/
2020-02-28 16:43:06.060 T:4076   DEBUG: Testing C:\Users\Z\AppData\Roaming\Kodi\addons\plugin.program.archivetest\resources\test.7z
(end of log)

Stacktrace:

Thread 4076 (process 2904)
#0

The plugin linked works on OSX and Linux. It's possible there are several flavors of each type of compression as well. The script doesn't currently account for those, but it would be fairly easy to set it up with some examples of each.

@zach-morris
Copy link
Contributor

Attached is a matrix compatible version, and the output on OSX (which works):

NOTICE: Archive Test Tool:  Tool Started
DEBUG: Testing .../resources/test.zip
DEBUG: Created folder .../resources/test_zip/test/ for archive .../resources/test.zip
DEBUG: Extracted file test1.txt from archive archive://...test.zip/test/
DEBUG: Extracted file test2.txt from archive archive://...test.zip/test/
DEBUG: Created folder .../resources/test_zip/test/test2/ for archive archive://...test.zip/test/
DEBUG: Extracted file test3.txt from archive archive://...test.zip/test/test2/
DEBUG: Extracted file test4.txt from archive archive://...test.zip/test/test2/
DEBUG: Testing .../resources/test.7z
DEBUG: Created folder .../resources/test_7z/test/ for archive .../resources/test.7z
DEBUG: Extracted file test1.txt from archive archive://...test.7z/test/
DEBUG: Extracted file test2.txt from archive archive://...test.7z/test/
DEBUG: Created folder .../resources/test_7z/test/test2/ for archive archive://...test.7z/test/
DEBUG: Extracted file test3.txt from archive archive://...test.7z/test/test2/
DEBUG: Extracted file test4.txt from archive archive://...test.7z/test/test2/
DEBUG: Testing .../resources/test.tar
DEBUG: Created folder .../resources/test_tar/test/ for archive .../resources/test.tar
DEBUG: Extracted file test1.txt from archive archive://...test.tar/test/
DEBUG: Extracted file test2.txt from archive archive://...test.tar/test/
DEBUG: Created folder .../resources/test_tar/test/test2/ for archive archive://...test.tar/test/
DEBUG: Extracted file test4.txt from archive archive://...test.tar/test/test2/
DEBUG: Extracted file test3.txt from archive archive://...test.tar/test/test2/
DEBUG: Testing .../resources/test.bz2
DEBUG: Created folder .../resources/test_bz2/test/ for archive .../resources/test.bz2
DEBUG: Extracted file test1.txt from archive archive://...test.bz2/test/
DEBUG: Extracted file test2.txt from archive archive://...test.bz2/test/
DEBUG: Created folder .../resources/test_bz2/test/test2/ for archive archive://...test.bz2/test/
DEBUG: Extracted file test4.txt from archive archive://...test.bz2/test/test2/
DEBUG: Extracted file test3.txt from archive archive://...test.bz2/test/test2/
DEBUG: Testing .../resources/test.rar
DEBUG: Extracted file test1.txt from archive .../resources/test.rar
DEBUG: Extracted file test2.txt from archive .../resources/test.rar
DEBUG: Extracted file test4.txt from archive .../resources/test.rar
DEBUG: Extracted file test3.txt from archive .../resources/test.rar
DEBUG: Testing .../resources/test.gz
DEBUG: Created folder .../resources/test_gz/test/ for archive .../resources/test.gz
DEBUG: Extracted file test1.txt from archive archive://...test.gz/test/
DEBUG: Extracted file test2.txt from archive archive://...test.gz/test/
DEBUG: Created folder .../resources/test_gz/test/test2/ for archive archive://...test.gz/test/
DEBUG: Extracted file test4.txt from archive archive://...test.gz/test/test2/
DEBUG: Extracted file test3.txt from archive archive://...test.gz/test/test2/
DEBUG: Testing .../resources/test.xz
DEBUG: Created folder .../resources/test_xz/test/ for archive .../resources/test.xz
DEBUG: Extracted file test1.txt from archive archive://...test.xz/test/
DEBUG: Extracted file test2.txt from archive archive://...test.xz/test/
DEBUG: Created folder .../resources/test_xz/test/test2/ for archive archive://...test.xz/test/
DEBUG: Extracted file test4.txt from archive archive://...test.xz/test/test2/
DEBUG: Extracted file test3.txt from archive archive://...test.xz/test/test2/
DEBUG: Testing .../resources/test.iso
DEBUG: Error extracting file . from archive .../resources/test.iso
DEBUG: Error extracting file test2 from archive .../resources/test.iso
DEBUG: Extracted file test1.txt from archive .../resources/test.iso
DEBUG: Extracted file test2.txt from archive .../resources/test.iso
DEBUG: Created folder .../resources/test_iso/test2/ for archive .../resources/test.iso
DEBUG: Extracted file test4.txt from archive archive://...test.iso/test2/
DEBUG: Extracted file test3.txt from archive archive://...test.iso/test2/
NOTICE: Archive Test Tool:  Tool completed

script.module.archive_tool.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants