Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of entries in the dropdown list #133

Open
recursivetree opened this issue Dec 12, 2021 · 2 comments
Open

Limit number of entries in the dropdown list #133

recursivetree opened this issue Dec 12, 2021 · 2 comments

Comments

@recursivetree
Copy link

When the dropdown list has many suggestions, they might get longer than the rest of the page. In my case, that results in the page overflowing at the bottom.

My question is if it is possible to add an option to limit the number of suggestions that are rendered.

Maybe there is a way to check if we are overflowing instead as a second option?

Bildschirmfoto 2021-12-12 um 21 14 00

@SantaFox
Copy link

SantaFox commented Feb 3, 2022

I think it is easier to limit results on server side, keeping the JavaScript smaller. The only reason to do it on client side is to write something line "There are 300 more results" in the last line

@recursivetree
Copy link
Author

it is easier sure, but you never know how big the browser will be. Depending on if it is a smartphone or desktop, the possible maximum length can be different. That goes more into the direction of the second option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants