Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch "pageerror" event #2

Open
k-kom opened this issue Jun 17, 2024 · 0 comments
Open

catch "pageerror" event #2

k-kom opened this issue Jun 17, 2024 · 0 comments
Assignees
@k-kom @notake
Labels
enhancement New feature or request

Comments

@k-kom
Copy link
Contributor

k-kom commented Jun 17, 2024 •
edited
Loading

Problem

Current implementation doesn't care if a page rendering is stopped because of unhandled exceptions.
This behaviour is a bit problematic:

  1. clients can't tell if a rendering process crashed
  2. clients have to wait until timeout elapses but it's unnecessary

Solution

Capture "pageerror" event and return 500 with the empty body.
@k-kom k-kom changed the title catch "pageerror" catch "pageerror" event Jun 17, 2024
@k-kom k-kom added the enhancement New feature or request label Jun 17, 2024
@k-kom k-kom self-assigned this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k-kom k-kom

@notake notake

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k-kom @notake