-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: merge snitch dialects #2885
Comments
I tend to agree with this sentiment, but I'd check in with @jorendumoulin since he was planning to use a similar lowering approach for the snax streamers which is slightly different. |
hello yes! It seems our lowering paths are like this:
I think the memref_stream abstraction definitely makes sense and is proving to be very useful for me. If merging the dialects means just moving over the operations, then fine (although memref_stream is quite snitch/risc-v-independent, so I'm not sure if this is logical). If it means actually changing the operations, this would be inconvenient for me. |
That's interesting and a good point. Thank you very much for commenting on this as this is super useful feedback! In that case I'd probably want to just get rid of the |
From experience trying to explain our lowerin in the paper and presentations, it seems that we have too many dialects to explain what's going on. I propose to move the riscv-specific operations to two dialects:
snitch
andriscv_snitch
.More concretely:
[Edited]
The text was updated successfully, but these errors were encountered: